-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canvas: Add tooltip for data links #61648
Conversation
Great job on this! Just noticed one UX issue that we may want to try and get right out of the gate. We currently display the tool tip on mouse enter / exit - it may potentially make more sense to display the tooltip based on hover instead so that tooltip follows the cursor E.g. I see the tooltip pop up and go to click the link and it disappears as I am triggering the mouse leave on the element - vs the tool tip follows the cursor it is less likely to click somewhere / cause tool tip to disappear by trying to click the data link. Thoughts? We probably can leave as is but doesn't feel as intuitive to me Screen.Recording.2023-01-19.at.12.17.44.PM.mov |
I see what you mean, it was intentional but we can definitely discuss it further. My reasoning -
But if it makes more sense to you, we can give it a try - it's a quick change! 😁 |
I think your approach is reasonable - in future it is a quick change so we can try it out in its current iteration :) This interaction is a little tricky so either way there are potentially tradeoffs - though like you mentioned this way at least the element will never be covered up fully. Great job on this feature! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
Hi @adela-almasan , @nmarrs thanks a lot for implementing this feature. This is what I had in mind. I'm Using an Influx db Database as a data source and running multiple queries to select the data I want to display in different Metric value elements. To get the Data link feature to work, I need to select the "value base field" option when selecting the field for the Metric Value. If I Select the field by the alias, e.g. in my case temp1, the link is not displayed (please refer to the Screenshots). Is there a way to specify the exact data links that should be displayed in each Metric value ? By the way, I'm running Grafana 9.4.3. here the working version |
@ChristophEbler we've added more steps to our docs but they're in the next version here: https://grafana.com/docs/grafana/next/panels-visualizations/visualizations/canvas/#data-links |
Thanks a lot works grate ! |
I can't to get this mouseover to become visible (nor the link on click). I followed the docs and am running v10.0.1 on Safari, Chrome, Firefox (macOS) |
I'm running v10.1.1 on Chrome. My data links also stopped working after one of the upgrades. |
Same with me. I'm using v10.1.5 locally. Datalink disappears soon after I click and try moving towards it. Same case once I save my dashboard and share it with users. |
Hi @kasaranenikarthik, @Hipska, and @PatiDeja - I'm sorry to hear that this feature isn't working anymore :/ would it be possible for you to provide a debug panel json for one of the panels you are having issues with? I just tested this on latest main (set up following the docs) and didn't have any issues 🤔 canvas.datalink.support.mov |
@nmarrs Thanks for getting back to me. It would be difficult to share the panel as it's on office network. But my elements are stacked exactly like in this #70079 (near to each other). I think placing element with datalink near to any other element could possibly be the issue (I'm not sure though ..just a thought). Also, another issue with canvas, I have canvas bigger than the size of my screen. Once I share, users are able to see only content equal to their screen size. Request for a horizontal and vertical scroll bars (even when editing the panel). |
I played around with this today in grafana 10.2.1. I noticed that if I add a data link for the entire panel, the tooltip displays for every element. I can click the element and then move to the tooltip and click the link (but I have to click the element, otherwise it just disappears before I can click the link) |
data_links_tooltip.mov
Fixes #61415
Fixes #57376
Special notes for your reviewer: